Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative link formatting in documentation to be consistent #68

Merged

Conversation

kiersten-stokes
Copy link
Collaborator

@kiersten-stokes kiersten-stokes commented Mar 3, 2023

In opening #67, the test failure alerted me to a new issue. I think the latest release of myst-parser was causing some new behavior that revealed these relative link warnings. That being said, the links work just fine both with and without this change. This basically just improves consistency with how other relative links are already handled (see other examples using relative paths in the devinstall.md file).

@kevin-bates kevin-bates added documentation Improvements or additions to documentation maintenance Repository maintenance labels Mar 3, 2023
@kevin-bates
Copy link
Member

A version update totally fits the bill - nice catch!

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thank you @kiersten-stokes!

@kevin-bates kevin-bates merged commit c7dcd88 into jupyter-server:main Mar 3, 2023
@welcome
Copy link

welcome bot commented Mar 3, 2023

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Repository maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants