Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup operators guide #57

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

kevin-bates
Copy link
Member

@kevin-bates kevin-bates commented Feb 16, 2023

This pull request brings the Operators Guide to an adequate point. In the course of this exercise, the docker build arguments for the spark base image were plumbed from the Makefile so that various options could be specified via the make command. In addition, a new BaseSpecSparkApp superclass was added for those provisioners that support Spark options. This addition enabled non-applicable spark options from showing up on provisioners that don't support spark (like the docker provisioners).

A fair amount of time was also spent trying to determine why the light and dark themes of pydata-sphinx-theme are not working - but no progress made there.

Resolves: #51

@kevin-bates kevin-bates added the documentation Improvements or additions to documentation label Feb 16, 2023
import enchant # type:ignore # noqa

extensions += ["sphinxcontrib.spelling"]
except ImportError:

Check notice

Code scanning / CodeQL

Empty except

'except' clause does nothing but pass and there is no explanatory comment.
]

try:
import enchant # type:ignore # noqa

Check notice

Code scanning / CodeQL

Unused import

Import of 'enchant' is not used.
@kevin-bates kevin-bates merged commit 9de8af8 into jupyter-server:main Feb 16, 2023
@kevin-bates kevin-bates deleted the cleanup-operators-guide branch February 16, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup Operators Guide
1 participant