Clean up lint and add check release #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay, this is passing on my fork, ready for review. |
kevin-bates
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Hi @blink1073 - thank you for this pull request! It does help solve some of the questions I had regarding jupyter-releaser. I went ahead and pushed a commit to update the docs since we list the available make targets.
This all looks great. I did have a question that I hope finally resolves my curiosity about typical contributor workflows since I see the push:branches:["main"] entry in a lot of repos. Could you please provide a response to that question?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #45.
This would get us to to be able to use releaser. More work would need to be done to move build logic into
hatch_build.py.