-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language Server Spec v1 #90
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
{ | ||
"title": "Python Language Server Configuration", | ||
"type": "object", | ||
"properties": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that these properties are too heavy here and would ideally be stored and/or available under a different endpoint, but it seems reasonable to start small and refactor later on. Maybe it will turn out that it works just fine as-is!
Is this still WIP, or should we merge? |
Ummm... It won't actually use the debug_argv yet, and I probably have to
take another look at the docs, but otherwise everything is good to go!
…On Tue, Nov 5, 2019, 15:58 M. Krassowski ***@***.***> wrote:
Is this still WIP, or should we merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/krassowski/jupyterlab-lsp/pull/90?email_source=notifications&email_token=AAALCRFRAK73O7JVSGSGS33QSHNAZA5CNFSM4JIHF3L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDEJQYY#issuecomment-550017123>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRB3RUK3QMDKF6CVXUTQSHNAZANCNFSM4JIHF3LQ>
.
|
For #89.
env
spec
nested under thesession
new example output
while definitely still wip, i'd love feedback here or on #89 as to what else might drive UI value...