Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook dependency to CI to test serverextension, fix CI #869

Merged
merged 10 commits into from
Dec 11, 2022

Conversation

krassowski
Copy link
Member

An attempt to fix CI failure seen in #867

@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch krassowski/jupyterlab-lsp/add-notebook-on-ci

@krassowski krassowski force-pushed the add-notebook-on-ci branch 2 times, most recently from 132c1a2 to 91d3edb Compare October 23, 2022 18:21
@krassowski
Copy link
Member Author

The lint failure is due to robottidy changing Test Tags to Force Tags (MarketSquare/robotframework-tidy#432) and then robocop complaining that it should be the other way. Nothing to do other than wait for a release upstream.

@bollwyvl
Copy link
Collaborator

bollwyvl commented Oct 23, 2022 via email

@krassowski
Copy link
Member Author

Kicking CI since the new release is already available and on conda-forge (thanks for a quick merge @bollwyvl).

@krassowski krassowski closed this Oct 28, 2022
@krassowski krassowski reopened this Oct 28, 2022
@krassowski krassowski marked this pull request as ready for review November 13, 2022 17:34
@krassowski krassowski closed this Nov 13, 2022
@krassowski krassowski reopened this Nov 13, 2022
@krassowski krassowski changed the title Add notebook dependency Add notebook dependency to CI to test serverextension, fix CI Nov 13, 2022
@krassowski
Copy link
Member Author

bash language server failures are gone (I did suspect this was an intermittent issue, waiting helped), but now MacOS smoke fails with cryptic:

+ jupyter labextension list
/Users/runner/work/_temp/03c846b0-ddaa-4fd7-be26-b0a115a5b859.sh: line 2: jupyter: command not found

but pip list shows all jupyter dependencies fine. I know we can workaround, but it sounds like an upstream problem again. Does it ring a bell?

This constant CI flake is really burning out energy.

@bollwyvl
Copy link
Collaborator

bollwyvl commented Nov 13, 2022

Perhaps try python3 -m jupyter?

Maybe some new jupyter_core path vulnerability fallout?

There is still the option of pinning the dependencies down harder with e.g. conda-lock, pip-tools so that handling issues like this can be a more intentional, single-purpose PR, if possible.

@bollwyvl
Copy link
Collaborator

It may also be worth upgrading the various setup-* actions to the latest versions, as things outside our control definitely will break in some places soon.

@krassowski
Copy link
Member Author

I will experiment in krassowski#3

@bollwyvl
Copy link
Collaborator

Perhaps this:

css:button[title="Refresh File List"]

Could be pointed at the more stable:

css:button[data-command="filebrowser:refresh"]

@bollwyvl
Copy link
Collaborator

Evaluating expression '__import__("urllib.request").request.urlopen("http://localhost:38635/@est/api/shutdown?token=jGIubKOf", data=[])' failed: URLError: <urlopen error [Errno 111] Connection refused>

This feels almost certainly related to the jupyter_core change, and might be fixable here:

Create Notebok Server Config
    # ...
    ${conf} =    Set Variable    ${NOTEBOOK DIR}${/}${JPSERVER CONF JSON}
    Set Environment Variable
    ...    name=JUPYTER_CONFIG_DIR
    ...    value=${NOTEBOOK DIR}

as an attempt to fix 'Handles Server Extension Failure'
test failures
@bollwyvl
Copy link
Collaborator

🎉 all 💚

@krassowski krassowski merged commit 37ab923 into jupyter-lsp:master Dec 11, 2022
@krassowski krassowski deleted the add-notebook-on-ci branch December 11, 2022 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants