Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lerna, metapackage, integrity checks, and move src (76 1️⃣ ) #79

Merged
merged 21 commits into from
Oct 30, 2019

Conversation

bollwyvl
Copy link
Collaborator

@bollwyvl bollwyvl commented Oct 28, 2019

For #76, continuing on #77, this does the Big Move of src and starts setting up the tooling for further work. It may or may not be appropriate to squash merge this: i tried to be concise but ended up creating a few more commits than I would have liked, but it's still reasonable to start working on step 2.

  • Moves src into a new sub-package
  • as few other changes as i could manage
  • creates new, unpublished "dev-only" root package
    • move all the test-time language servers here
    • move most scripts (not test) here
  • adds new, unpublished metapackage
    • includes references in tsconfig to jupyterlab-lsp
      • keeping these versions in-line is a bit of a chore, and should probably be managed with an integrity script a la lab
  • changes the lab build strategy for ci (pack, install, build) vs binder (link, install, build)
    • this will likely have to change some as we introduce packages that aren't labextensions
  • add integrity script to check metapackage versions and refs (also other things)
  • update docs

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@bollwyvl bollwyvl changed the title add lerna, metapackage, and move src (step 1️⃣ ) add lerna, metapackage, and move src (76 1️⃣ ) Oct 28, 2019
@bollwyvl bollwyvl changed the title add lerna, metapackage, and move src (76 1️⃣ ) [WIP] add lerna, metapackage, and move src (76 1️⃣ ) Oct 28, 2019
@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Oct 28, 2019 via email

@bollwyvl
Copy link
Collaborator Author

Huzzah, mostly-working pass. Despite my desire to keep this a manageable review, the metapackage demanded that I start thinking more about the integrity stuff, so I've gone ahead and added that to CI... still want to do some stuff on here, will start a punchlist above.

@bollwyvl
Copy link
Collaborator Author

I had another go through the docs... given there is just the one "real" package and the metapackage, there isn't a lot to say that's new, but I did catch (and add a test for) the version of the package listed in /README.md. If this goes green, it's probably ready for review...

@bollwyvl bollwyvl changed the title [WIP] add lerna, metapackage, and move src (76 1️⃣ ) add lerna, metapackage, integrity checks, and move src (76 1️⃣ ) Oct 30, 2019
@bollwyvl bollwyvl requested a review from krassowski October 30, 2019 00:25
@bollwyvl
Copy link
Collaborator Author

Yep, probably done on this for the time being. No rush to review. I'll check out #78 and see if there's a way to do server discovery that makes sense.

@@ -120,7 +120,7 @@ jupyter labextension update @krassowski/jupyterlab-lsp
Use install command (update does not seem to work) appending `@version` to the extension name, like this:

```bash
jupyter labextension install @krassowski/jupyterlab-lsp@0.5.0-rc.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the point here was to demonstrate the RC installation. It's a pity I rushed through with soft release, though I do not feel that we need this integrity check for this part - other than this example, we do not need the version in the README. Though I am also happy for it to stay - as-is.

@bollwyvl
Copy link
Collaborator Author

bollwyvl commented Oct 30, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants