-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lerna, metapackage, integrity checks, and move src (76 1️⃣ ) #79
Conversation
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Boo, need to chomp the line break on the variables in the yaml...
|
Huzzah, mostly-working pass. Despite my desire to keep this a manageable review, the |
I had another go through the docs... given there is just the one "real" package and the metapackage, there isn't a lot to say that's new, but I did catch (and add a test for) the version of the package listed in |
Yep, probably done on this for the time being. No rush to review. I'll check out #78 and see if there's a way to do server discovery that makes sense. |
@@ -120,7 +120,7 @@ jupyter labextension update @krassowski/jupyterlab-lsp | |||
Use install command (update does not seem to work) appending `@version` to the extension name, like this: | |||
|
|||
```bash | |||
jupyter labextension install @krassowski/jupyterlab-lsp@0.5.0-rc.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the point here was to demonstrate the RC installation. It's a pity I rushed through with soft release, though I do not feel that we need this integrity check for this part - other than this example, we do not need the version in the README. Though I am also happy for it to stay - as-is.
Either way! Sometimes it's great to have the version in the readme, others,
more so much...
…On Wed, Oct 30, 2019, 16:52 M. Krassowski ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In README.md
<https://github.com/krassowski/jupyterlab-lsp/pull/79#discussion_r340852028>
:
> @@ -120,7 +120,7 @@ jupyter labextension update @krassowski/jupyterlab-lsp
Use install command (update does not seem to work) appending ***@***.***` to the extension name, like this:
```bash
-jupyter labextension install @***@***.***
Well, the point here was to demonstrate the RC installation. It's a pity I
rushed through with soft release, though I do not feel that we need this
integrity check for this part - other than this example, we do not need the
version in the README. Though I am also happy for it to stay - as-is.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/krassowski/jupyterlab-lsp/pull/79?email_source=notifications&email_token=AAALCRC6L2CZIOPPN3NXJI3QRHXZFA5CNFSM4JFZDSDKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJZM3SQ#pullrequestreview-309513674>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALCRAGMLUPSDF7EKIRQ7DQRHXZFANCNFSM4JFZDSDA>
.
|
For #76, continuing on #77, this does the Big Move of
src
and starts setting up the tooling for further work. It may or may not be appropriate to squash merge this: i tried to be concise but ended up creating a few more commits than I would have liked, but it's still reasonable to start working on step 2.src
into a new sub-packagescripts
(nottest
) heremetapackage
references
intsconfig
tojupyterlab-lsp
pack
,install
,build
) vs binder (link
,install
,build
)metapackage
versions and refs (also other things)