Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Jupyter Enhancement Proposal for LSP #623

Closed
wants to merge 9 commits into from

Conversation

krassowski
Copy link
Member

Hi @bollwyvl, @jtpio and everyone else who contributed in the past, please have a look at the draft JEP proposing inclusion of LSP as a subproject of Jupyter.

If you leave any comments and/or approve this draft I will add you as a co-author (please opt out if you prefer not be named as a co-author).

A small conflict with the template is that it assumes that the proposing party brings a complete solution that should become a part of a Jupyter standard; however this JEP proposes to adopt an existing standard and does not claim to have a best solution for the actual implementation just yet, but merely brings a proof-of-concept implementation together with concrete plan on how to move forward and improve it. I hope this is ok.

Addresses https://github.com/krassowski/jupyterlab-lsp/issues/238#issuecomment-851712651

@krassowski
Copy link
Member Author

If there are no unresolved change requests prior to 27 of June (00:01 UTC), I will then close this PR and open it on the Jupyter JEP repository.

@krassowski krassowski requested a review from bollwyvl June 12, 2021 13:42
@jtpio
Copy link
Member

jtpio commented Jun 14, 2021

Thanks for opening this!

however this JEP proposes to adopt an existing standard and does not claim to have a best solution for the actual implementation just yet, but merely brings a proof-of-concept implementation together with concrete plan on how to move forward and improve it. I hope this is ok.

Sounds like it would be fine, and for reference the debugger did something similar by adopting the DAP (jupyter/enhancement-proposals#47)

JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
krassowski and others added 2 commits June 14, 2021 10:35
So many typos, I should have passed it via a spellchecker. Sorry about it and thanks!

Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
JEP.md Outdated Show resolved Hide resolved
@krassowski
Copy link
Member Author

@bollwyvl, any comments? Aiming to send a PR tomorrow.

JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
JEP.md Outdated Show resolved Hide resolved
@bollwyvl
Copy link
Collaborator

Sorry for my delay in reviewing this. I think it's a very good start.

Before punching the PR, I might suggest running it through prettier with prosewrap on (the GH UI is about 100 chars) as it can be a little easier to comment on/fix up a line rather than a whole paragraph.

@krassowski
Copy link
Member Author

Thank you for the reviews and suggestions, I now opened jupyter/enhancement-proposals#72, let's move further discussion there :).

@krassowski krassowski closed this Jun 27, 2021
@krassowski krassowski deleted the jep-proposal branch June 27, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants