-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Jupyter Enhancement Proposal for LSP #623
Conversation
If there are no unresolved change requests prior to 27 of June (00:01 UTC), I will then close this PR and open it on the Jupyter JEP repository. |
Thanks for opening this!
Sounds like it would be fine, and for reference the debugger did something similar by adopting the DAP (jupyter/enhancement-proposals#47) |
So many typos, I should have passed it via a spellchecker. Sorry about it and thanks! Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
Co-authored-by: Jeremy Tuloup <jeremy.tuloup@gmail.com>
@bollwyvl, any comments? Aiming to send a PR tomorrow. |
Sorry for my delay in reviewing this. I think it's a very good start. Before punching the PR, I might suggest running it through |
Thank you for the reviews and suggestions, I now opened jupyter/enhancement-proposals#72, let's move further discussion there :). |
Hi @bollwyvl, @jtpio and everyone else who contributed in the past, please have a look at the draft JEP proposing inclusion of LSP as a subproject of Jupyter.
If you leave any comments and/or approve this draft I will add you as a co-author (please opt out if you prefer not be named as a co-author).
A small conflict with the template is that it assumes that the proposing party brings a complete solution that should become a part of a Jupyter standard; however this JEP proposes to adopt an existing standard and does not claim to have a best solution for the actual implementation just yet, but merely brings a proof-of-concept implementation together with concrete plan on how to move forward and improve it. I hope this is ok.
Addresses https://github.com/krassowski/jupyterlab-lsp/issues/238#issuecomment-851712651