jupyter-lsp · krassowski · Nov 5, 2020 · Oct 8, 2020 · Oct 8, 2020 · Nov 3, 2020
diff --git a/.github/workflows/job.test.yml b/.github/workflows/job.test.yml
@@ -32,6 +32,8 @@ jobs:
     runs-on: ${{ matrix.os }}
     name: ${{ matrix.os }}, Python ${{ matrix.python }}, Node ${{ matrix.nodejs }}
     strategy:
+      # TODO: maybe turn back on
+      fail-fast: false
       matrix:
         python: [3.6, 3.7, 3.8]
         os: [ubuntu-16.04, macos-10.14, vs2017-win2016]
@@ -83,9 +85,6 @@ jobs:
           auto-update-conda: true
           use-only-tar-bz2: true # needs to be set for caching to work properly
 
-      - name: Install pip dependencies
-        run: pip install pytest-github-actions-annotate-failures
-
       - name: Describe conda
         shell: bash -l {0}
         run: |
@@ -105,7 +104,7 @@ jobs:
             yarn-
 
       - name: Install npm dependencies
-        run: jlpm
+        run: jlpm --ignore-optional
 
       - name: Build the extension
         run: jlpm build
@@ -145,6 +144,7 @@ jobs:
         run: python scripts/tectonic_cache.py
 
       - name: Run frontend unit tests
+        if: ${{ !contains(matrix.os, 'win') }}
         run: jlpm test
 
       #  js_cov_packages:

diff --git a/.gitignore b/.gitignore
@@ -113,6 +113,6 @@ atest/output/
 junit.xml
 coverage/
 .vscode/
-_schema.d.ts
+_*.d.ts
 _build
 .virtual_documents/
diff --git a/atest/03_Notebook.robot b/atest/03_Notebook.robot
@@ -14,12 +14,12 @@ Python
 Foreign Extractors
     ${file} =    Set Variable    Foreign extractors.ipynb
     Configure JupyterLab Plugin
-    ...    {"language_servers": {"texlab": {"serverSettings": {"latex.lint.onChange": true}}}}
+    ...    {"language_servers": {"texlab": {"serverSettings": {"latex.lint.onChange": true}}, "bash-langauge-server": {"bashIde.highlightParsingErrors": true}}}
     Capture Page Screenshot    10-configured.png
     Reset Application State
     Setup Notebook    Python    ${file}
     @{diagnostics} =    Create List
-    ...    Failed to parse expression    # bash
+    ...    Failed to parse expression    # bash, configured by spec.env
     ...    ame 'valid'    # python, mypy and pyflakes will fight over `(N|n)ame 'valid'`, just hope for the best
     ...    Trailing whitespace is superfluous.    # r
     ...    `frob` is misspelt    # markdown

diff --git a/atest/07_Configuration.robot b/atest/07_Configuration.robot
@@ -13,8 +13,7 @@ Python
     ...    undefined name 'foo' (flake8)
 
 YAML
-    [Documentation]    EXPECT FAIL Composer YAML files don't allow a "greetings" key
-    [Tags]    expect:fail
+    [Documentation]    Composer YAML files don't allow a "greetings" key
     Settings Should Change Editor Diagnostics    YAML    example.yaml    yaml-language-server
     ...    {"yaml.schemas": {"http://json.schemastore.org/composer": "*"}}
     ...    duplicate key

diff --git a/atest/examples/Code overrides.ipynb b/atest/examples/Code overrides.ipynb
@@ -35,7 +35,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Completion.ipynb b/atest/examples/Completion.ipynb
@@ -142,7 +142,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.8.0"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Diagnostic.ipynb b/atest/examples/Diagnostic.ipynb
@@ -66,7 +66,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Foreign extractors.ipynb b/atest/examples/Foreign extractors.ipynb
@@ -119,7 +119,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.6"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Hover.ipynb b/atest/examples/Hover.ipynb
@@ -55,7 +55,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Panel.ipynb b/atest/examples/Panel.ipynb
@@ -35,7 +35,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Python.ipynb b/atest/examples/Python.ipynb
@@ -35,7 +35,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.8.0"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Signature.ipynb b/atest/examples/Signature.ipynb
@@ -45,7 +45,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.8.0"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/examples/Syntax highlighting.ipynb b/atest/examples/Syntax highlighting.ipynb
@@ -100,7 +100,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/atest/ports.py b/atest/ports.py
@@ -4,9 +4,9 @@
 
 
 def get_unused_port():
-    """ Get an unused port by trying to listen to any random port.
+    """Get an unused port by trying to listen to any random port.
 
-        Probably could introduce race conditions if inside a tight loop.
+    Probably could introduce race conditions if inside a tight loop.
     """
     sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
     sock.bind(("localhost", 0))

diff --git a/docs/Architecture.ipynb b/docs/Architecture.ipynb
@@ -165,7 +165,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/CHANGELOG.ipynb b/docs/CHANGELOG.ipynb
@@ -42,7 +42,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.6"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/Configuring.ipynb b/docs/Configuring.ipynb
@@ -206,7 +206,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/Contributing.ipynb b/docs/Contributing.ipynb
@@ -44,7 +44,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.6"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/Extending.ipynb b/docs/Extending.ipynb
@@ -301,7 +301,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/Installation.ipynb b/docs/Installation.ipynb
@@ -308,7 +308,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.6"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/Language Servers.ipynb b/docs/Language Servers.ipynb
@@ -42,6 +42,7 @@
     "\n",
     "import IPython\n",
     "from jinja2 import Template\n",
+    "\n",
     "from jupyter_lsp import LanguageServerManager"
    ]
   },
@@ -278,7 +279,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.6"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/Releasing.ipynb b/docs/Releasing.ipynb
@@ -99,9 +99,9 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,
  "nbformat_minor": 4
-}
+}
diff --git a/docs/Roadmap.ipynb b/docs/Roadmap.ipynb
@@ -59,7 +59,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/docs/conf.py b/docs/conf.py
@@ -102,7 +102,6 @@
 
 
 def setup(app):
-    """ Runs before the "normal business" of sphinx. Don't go too crazy here.
-    """
+    """Runs before the "normal business" of sphinx. Don't go too crazy here."""
     app.add_css_file("css/custom.css")
     subprocess.check_call(["jlpm", "--ignore-optional"])
diff --git a/docs/index.ipynb b/docs/index.ipynb
@@ -78,7 +78,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.7.5"
+   "version": "3.7.9"
   }
  },
  "nbformat": 4,

diff --git a/package.json b/package.json
@@ -1,12 +1,12 @@
 {
   "dependencies": {},
   "devDependencies": {
-    "@typescript-eslint/eslint-plugin": "^2.27.0",
-    "@typescript-eslint/parser": "^2.27.0",
-    "bash-language-server": "^1.6.1",
+    "@typescript-eslint/eslint-plugin": "^3.10.1",
+    "@typescript-eslint/parser": "^3.10.1",
+    "bash-language-server": "^1.17.0",
     "dictionary-en": "^3.0.0",
     "dockerfile-language-server-nodejs": "^0.0.22",
-    "eslint": "^6.8.0",
+    "eslint": "^7.5.0",
     "eslint-config-prettier": "^6.7.0",
     "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-jest": "^23.8.2",
@@ -17,14 +17,15 @@
     "jest-github-actions-reporter": "^1.0.2",
     "lerna": "^3.13.2",
     "precise-commits": "^1.0.2",
-    "prettier": "^2.0.5",
+    "prettier": "^2.1.2",
     "sql-language-server": "^0.11.4",
-    "typescript": "~3.9.5",
+    "typescript": "~4.0.2",
     "unified-language-server": "^0.3.0",
     "vscode-css-languageserver-bin": "^1.4.0",
     "vscode-html-languageserver-bin": "^1.4.0",
     "vscode-json-languageserver-bin": "^1.0.1",
-    "yaml-language-server": "~0.4.0"
+    "yaml-language-server": "^0.12.0",
+    "vscode-json-languageservice": "^3.9.1 <3.10.0"
   },
   "husky": {
     "hooks": {}

diff --git a/packages/.eslintrc.js b/packages/.eslintrc.js
@@ -21,21 +21,18 @@ module.exports = {
     '**/_*.ts',
     '**/_*.d.ts',
     '**/typings/**/*.d.ts',
-    '**/dist/*'
+    '**/dist/*',
+    'packages/.eslintrc.js'
   ],
   parser: '@typescript-eslint/parser',
   parserOptions: {
     project: 'packages/tsconfig.eslint.json'
   },
   plugins: ['@typescript-eslint', 'jest', 'import'],
   rules: {
-    '@typescript-eslint/ban-ts-ignore': 'warn',
     '@typescript-eslint/camelcase': 'off',
     '@typescript-eslint/explicit-function-return-type': 'off',
-    '@typescript-eslint/interface-name-prefix': [
-      'error',
-      { prefixWithI: 'always' }
-    ],
+    '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-empty-interface': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-floating-promises': ['error', { ignoreVoid: true }],

diff --git a/packages/jupyterlab-go-to-definition/jest.config.js b/packages/jupyterlab-go-to-definition/jest.config.js
@@ -10,7 +10,7 @@ const reuseFromUpstream = [
 ];
 
 let local = {
-  globals: { 'ts-jest': { tsConfig: 'tsconfig.json' } },
+  globals: { 'ts-jest': { tsconfig: 'tsconfig.json' } },
   testRegex: `.*\.spec\.tsx?$`,
   transform: {
     '\\.(ts|tsx)?$': 'ts-jest',

diff --git a/packages/jupyterlab-go-to-definition/package.json b/packages/jupyterlab-go-to-definition/package.json
@@ -50,7 +50,7 @@
     "@jupyterlab/apputils": "~2.2.0",
     "@jupyterlab/codeeditor": "~2.2.0",
     "@jupyterlab/codemirror": "~2.2.0",
-    "@jupyterlab/coreutils": "~4.0.0",
+    "@jupyterlab/coreutils": "~4.2.0",
     "@jupyterlab/docmanager": "~2.2.0",
     "@jupyterlab/docregistry": "~2.2.0",
     "@jupyterlab/fileeditor": "~2.2.0",
@@ -65,11 +65,11 @@
     "@types/chai": "^4.1.7",
     "@types/jest": "^23.3.11",
     "chai": "^4.2.0",
-    "jest": "^24.7.1",
+    "jest": "^26.0.0",
     "jest-junit": "^8.0.0",
     "rimraf": "^2.6.1",
-    "ts-jest": "^24.0.2",
-    "typescript": "~3.9.5",
+    "ts-jest": "^26.4.3",
+    "typescript": "~4.0.2",
     "@babel/preset-env": "^7.4.3"
   },
   "jupyterlab": {

diff --git a/packages/jupyterlab-go-to-definition/src/editors/codemirror/extension.ts b/packages/jupyterlab-go-to-definition/src/editors/codemirror/extension.ts
@@ -32,7 +32,8 @@ function getModifierState(event: MouseEvent, modifierKey: string): boolean {
   }
 }
 
-export class CodeMirrorExtension extends CodeMirrorTokensProvider
+export class CodeMirrorExtension
+  extends CodeMirrorTokensProvider
   implements IEditorExtension {
   jumper: CodeJumper;
   static modifierKey: KeyModifier;

diff --git a/packages/jupyterlab-go-to-definition/src/jumpers/jumper.ts b/packages/jupyterlab-go-to-definition/src/jumpers/jumper.ts
@@ -358,7 +358,7 @@ export abstract class CodeJumper {
     }
   }
 
-  handle_kernel_inspect(response: IIOPubMessage, fallback: Function) {
+  handle_kernel_inspect(response: IIOPubMessage, fallback: () => void) {
     let obj: any = response.content;
     if (obj.name === 'stdout') {
       let data = JSON.parse(obj.text);
@@ -386,8 +386,8 @@ export abstract class CodeJumper {
   protected inspect_and_jump(
     context: TokenContext,
     cell_of_origin_analyzer: LanguageAnalyzer,
-    fallback: Function,
-    callback: Function
+    fallback: () => void,
+    callback: () => void
   ) {
     let code = cell_of_origin_analyzer.definitionLocationQuery(context);