Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub templates #101

Merged
merged 3 commits into from
Nov 30, 2019
Merged

Conversation

bollwyvl
Copy link
Collaborator

Just to get the ball rolling...

References

#96

Code changes

N/A

User-facing changes

Contributors/end users will see a little more UI when making PRs/Issues: https://help.github.com/en/github/building-a-strong-community/about-issue-and-pull-request-templates

Backwards-incompatible changes

N/A

Chores

  • linted
  • tested
  • documented
  • changelog entry

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@bollwyvl
Copy link
Collaborator Author

Great: this demonstrated the flake on win/py37, and it was corrected in the third run. The test failures are still captured in the test results:
https://dev.azure.com/krassowskimichal/jupyterlab-lsp/_build/results?buildId=155&view=ms.vss-test-web.build-test-results-tab

and the robot logs have a (relatively) clear representation of what flaked:
Screenshot from 2019-11-17 13-40-38

The overall runtime was 33min, which is better than 40min if we re-kicked the whole thing, and certainly better, since we didn't have to do anything manually.

@krassowski krassowski merged commit 0913d36 into jupyter-lsp:master Nov 30, 2019
@krassowski
Copy link
Member

Thank you, the templates are great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants