Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin ipykernel<6.0.0 #723

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Pin ipykernel<6.0.0 #723

merged 2 commits into from
Aug 17, 2021

Conversation

devstein
Copy link
Collaborator

@devstein devstein commented Jul 23, 2021

Closes #492

Description

Changes to the async behavior in IPykernel >=6.0.0 causes connection issues with the Sparkmagic (Py)Spark kernels. This pins the dependency while I find the root cause of the breaking change.

  • Pins ipykernel<6.0.0
  • Removes more references to Python 2
  • Runs black formatter

Checklist

  • Wrote a description of my changes above
  • Added a bullet point for my changes to the top of the CHANGELOG.md file
  • Manually tested with a notebook

devstein added 2 commits July 22, 2021 10:05
Remove old refernces to Python 2.7
Copy link
Contributor

@itamarst itamarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine assuming tests pass.

@devstein
Copy link
Collaborator Author

devstein commented Aug 10, 2021

@itamarst CI is broken because of a Travis CI migration (see below). I've reached out to the maintainer of the pip package, so I can migrate to GH Actions

Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.

@Carreau
Copy link
Member

Carreau commented Aug 10, 2021

Thanks seem fine to me, I do have access to PyPI as a maintainer, though I believe I can only upload as I don't have access to any settings panels.

One caveat for this fix: now that pip has a resolver, once this get published, pip can decide that the solution is to not upgrade sparkmagic; I've seen similar behavior in the wild, so we might have to yank

@itamarst
Copy link
Contributor

Yeah, probably need to:

  1. Switch to Github Actions (GHA).
  2. Generate new PyPI access token, and add it to GHA for auto-release-on-tag, like Travis currently does.

@devstein
Copy link
Collaborator Author

@itamarst Agreed.

Thanks seem fine to me, I do have access to PyPI as a maintainer, though I believe I can only upload as I don't have access to any settings panels.

@Carreau Do you have access to generate a PyPI access token? If so, can you generate a new token and set it as an environment variable for the sparkmagic repo? I

@Carreau
Copy link
Member

Carreau commented Aug 12, 2021

I believe this is now done with a repository secret.

Do you know who hdinsightmsftagu on PyPI is ? Or how to contact them ? Otherwise we can make a request to PyPI maintainer to transfer ownership – it should not be too hard as I'm already maintainer.

@devstein
Copy link
Collaborator Author

@Carreau Thank you! I'll create another PR in the next few days to migrate to GH actions and tag you.

Do you know who hdinsightmsftagu on PyPI is ? Or how to contact them ? Otherwise we can make a request to PyPI maintainer to transfer ownership – it should not be too hard as I'm already maintainer.

I do not. This is the only maintainer I couldn't find information about. It seems like it's a service account. If you can reach out to PyPI that would be great. It's the simplest option.

@Carreau
Copy link
Member

Carreau commented Aug 12, 2021 via email

@Carreau
Copy link
Member

Carreau commented Aug 13, 2021

I have an update and we might be able to get everyone as an owner in a week or so - some people are travelling and put their work notification off.

@devstein
Copy link
Collaborator Author

@Carreau Amazing, thank you for all the help on this.

@Carreau
Copy link
Member

Carreau commented Aug 14, 2021

@Carreau Amazing, thank you for all the help on this.

No problem, thank you for working on this. We are also working on making sure that access to resources is managed in a better way.

Do you also have a PyPI username, I supposed it will not be a problem to add you once we get back ownership.

@devstein
Copy link
Collaborator Author

@mrinmoyprasad
Copy link

Hi @devstein - do you think my issue here could be related to the bug your PR is addressing?

@devstein devstein mentioned this pull request Aug 17, 2021
2 tasks
@devstein
Copy link
Collaborator Author

@mrinmoyprasad Hard to say without investigating further. Would you mind trying to reproduce to verify after the next release?

@devstein devstein merged commit 5140998 into master Aug 17, 2021
@devstein devstein deleted the devstein/pin-ipykernel branch August 17, 2021 00:27
@devstein
Copy link
Collaborator Author

@Carreau I'm having issues publishing the packages. The error message indicates an invalid token, here are the probably root causes

Any ideas what could be wrong with the token? Let me know if I can help.

Upload failed (403): Invalid API Token: InvalidMacaroon('invalid macaroon signature')
error: Upload failed (403): Invalid API Token: InvalidMacaroon('invalid macaroon signature')
Error: Process completed with exit code 1.

@Carreau
Copy link
Member

Carreau commented Aug 17, 2021

I've updated the token, and you should have received an invite.

@mrinmoyprasad
Copy link

@mrinmoyprasad Hard to say without investigating further. Would you mind trying to reproduce to verify after the next release?

Sure thing, as soon as 0.19.1 is published, I can verify and let you know! Thank you

@devstein
Copy link
Collaborator Author

@Carreau Thanks! I now have access tosparkmagic; however, I discovered the source of the error 403 is that the token is only valid for sparkmagic and not hdijupyterutils nor autovizwidget.

@ellisonbg is the only one with access to hdijupyterutils and autovizwidget. Are you able to reach out to him?

@Carreau
Copy link
Member

Carreau commented Aug 19, 2021

I'll see what I can do, though I'll be offline until next Wednesday.

@Carreau
Copy link
Member

Carreau commented Aug 25, 2021

There should now be 3 new tokens : PYPI_TOKEN_AUTOVIZWIDGET, PYPI_TOKEN_HDIJUPYTERUTILS, PYPI_TOKEN_SPARKMAGIC with upload access to corresponding repos.

@mrinmoyprasad
Copy link

@devstein It looks like 0.19.1 fixed our issues with sparkmagic that I had logged in here! Thank you so much for identifying this, this had plagued us for over 2 months at this point. Really appreciate your help on this.

@devstein
Copy link
Collaborator Author

There should now be 3 new tokens : PYPI_TOKEN_AUTOVIZWIDGET, PYPI_TOKEN_HDIJUPYTERUTILS, PYPI_TOKEN_SPARKMAGIC with upload access to corresponding repos.

@Carreau Amazing, thanks for all the support on this! Hope you enjoyed your the time offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with pyspark(3) kernel: TypeError: 'Future' object is not subscriptable
4 participants