-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⌨️ Code cell options can have caption #1726
Conversation
🦋 Changeset detectedLatest commit: 4e2412c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Though I am also confused as isn't this already possible? Here's a screenshot that seems to show a code block with a caption:
This is code-cell! Not code. |
Oh nice! I updated the PR title as I think you meant "cell" and that was what confused me. The PR looks good to go from me but I had a quick question for feedback: When we merge this, it'll auto-populate our docs here right? https://mystmd.org/guide/directives#directive-code-cell Thinking through the documentation strategy, does this sound correct to you:
Does that sound right? |
Yes, docs autoupdate for all directive options. I have added additional docs about the caption. The mystmd docs should also be stand-alone from Jupyter Book (i.e. a user coming to mystmd.org can get up and running with the myst cli with the relevant tutorials, without having to know about jupyter book), so there still needs to be some guides and tutorials in the mystmd docs, just more of a focus on reference material over time. This will likely become more clear as JBv2 gets released fully and has more docs focused on building books and how-tos etc. |
We already allow this for options defined with the
#| caption:
syntax, this expands to being allowed in the code-block options as well.