Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Validate SCS #173

Merged
merged 2 commits into from
May 9, 2023
Merged

Validate SCS #173

merged 2 commits into from
May 9, 2023

Conversation

kanocrypto
Copy link
Contributor

Validate SCS

Attestations (Please provide links):

Validation (Please check off boxes):

  • The metadata provided in the PR matches what is on-chain (Mandatory)
  • Does not duplicate the symbol of another token on Jupiter's strict list (If not, review will be delayed)
  • Is Listed on Coingecko / CMC (Optional, but helpful for reviewers)

Acknowledgement (Please check off boxes)

  • My change matches the format in the file (no spaces between fields).
  • My token is already live and trading on Jupiter.
  • !!! I read the README section on Community-Driven Validation and understand this PR will be only be reviewed when there is community support on Twitter.

@kanocrypto
Update validated-tokens.csv
4a5a600 
Added "Solcasino Token" SCS
@Timoon21 Timoon21 changed the title Update validated-tokens.csv Add Solcasino Token Validate SCS May 8, 2023
Timoon21
Timoon21 previously approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@Timoon21 Timoon21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On-chain metadata matches the PR
  • Token address matches the tweet
  • No duplication on Jupiter's strict list
  • No duplication on CMC/CoinGecko
  • Community validation

@9yoi 9yoi self-requested a review May 9, 2023 02:47
9yoi
9yoi approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@9yoi 9yoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The token should be listed with "true" for community validated and moved to the bottom of the list. I fixed it

@9yoi
Copy link
Contributor

9yoi commented May 9, 2023

  • On-chain metadata matches the PR
  • Token address matches the tweet
  • No duplication on Jupiter's strict list
  • No duplication on CMC/CoinGecko
  • Community validation

their initial commit was tagged community validated "false", which was wrong. (We should refactor our stuff to separate community validated tokens and remove the boolean tag but until then, gotta check).

@Timoon21 Timoon21 merged commit 428bb08 into jup-ag:main May 9, 2023
derbstation added a commit to derbstation/token-list-1 that referenced this pull request May 10, 2023
@derbstation @anishfai
@9yoi @patback93 @Timoon21 @kanocrypto
Validate $Beedo (#1)
d9de40a 
* Add ISC to the validated tokens list (jup-ag#165)

Co-authored-by: Anish Tamse <anish@fasterai.io>
Co-authored-by: mpng <mpng@raccoons.dev>

* Validate $POOR (jup-ag#172)

* Update validated-tokens.csv

* Update validated-tokens.csv

Co-authored-by: Timoon21 <95104873+Timoon21@users.noreply.github.com>

---------

Co-authored-by: Timoon21 <95104873+Timoon21@users.noreply.github.com>
Co-authored-by: mpng <mpng@raccoons.dev>

* Update README.md

* Update validated-tokens.csv (jup-ag#173)

Added "Solcasino Token" SCS

Co-authored-by: mpng <mpng@raccoons.dev>

---------

Co-authored-by: theISCTeam <128073058+theISCTeam@users.noreply.github.com>
Co-authored-by: Anish Tamse <anish@fasterai.io>
Co-authored-by: mpng <mpng@raccoons.dev>
Co-authored-by: patback93 <132713631+patback93@users.noreply.github.com>
Co-authored-by: Timoon21 <95104873+Timoon21@users.noreply.github.com>
Co-authored-by: kanocrypto <131653599+kanocrypto@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timoon21 Timoon21 Timoon21 approved these changes

@9yoi 9yoi 9yoi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kanocrypto @9yoi @Timoon21