Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): remove attribute when is "false" #190

Merged
merged 16 commits into from
Jul 25, 2023
Merged

fix(react): remove attribute when is "false" #190

merged 16 commits into from
Jul 25, 2023

Conversation

igorwessel
Copy link
Contributor

@igorwessel igorwessel commented Jul 17, 2023 •
edited
Loading

Infos

Task

What is being delivered?

We are adding a fix after finishing transpiling the components to React.

  1. After generate file: attachProps.ts
  2. Replace the part of the code responsible for assigning attributes in the web-component Element.

What impacts?

  • Transpiler for React

Reversal plan

Reset commit to the previous version 7809bb3

Evidences

Storybook - React

Gravacao.de.Tela.2023-07-18.as.17.45.05.mov

Build

Gravacao.de.Tela.2023-07-19.as.17.44.20.mov

Build in watch mode

Gravacao.de.Tela.2023-07-19.as.17.46.48.mov

@igorwessel igorwessel added the bug Something isn't working label Jul 17, 2023
@igorwessel igorwessel self-assigned this Jul 17, 2023
@igorwessel igorwessel requested review from felipefialho, a team and LucasGomestl and removed request for a team July 17, 2023 20:45
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-07-25 11:11 UTC

@igorwessel igorwessel marked this pull request as draft July 17, 2023 21:05
@igorwessel
Copy link
Contributor Author

Some links about this problem:

https://custom-elements-everywhere.com/#react

ionic-team/stencil-ds-output-targets#123

facebook/react#11347

@igorwessel igorwessel changed the title fix(button): remove attribute "disabled" when is Falsy fix(react): remove attribute when is "false" Jul 19, 2023
@igorwessel igorwessel marked this pull request as ready for review July 19, 2023 20:51
@igorwessel igorwessel requested review from schirrel, tassioFront, a team and mauriciomutte July 19, 2023 20:52
@igorwessel igorwessel force-pushed the fix/disabled-in-button-host branch 3 times, most recently from 7c8424c to 32dc49d Compare July 21, 2023 15:03
@igorwessel igorwessel force-pushed the fix/disabled-in-button-host branch from 32dc49d to 3e48fe8 Compare July 21, 2023 17:30
@BernardoSemiOficial
Copy link

🚀

@sonarqubecloud
Copy link

[juntossomosmais_atomium_core] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@igorwessel igorwessel merged commit 373d16e into main Jul 25, 2023
@igorwessel igorwessel deleted the fix/disabled-in-button-host branch July 25, 2023 11:06
This was referenced Jul 25, 2023
Merged
Closed
Merged
@github-actions github-actions bot mentioned this pull request Aug 2, 2023
Merged
felipefialho pushed a commit that referenced this pull request Aug 3, 2023
@igorwessel
fix(react): remove attribute when is "false" (#190)
a34b075
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BernardoSemiOficial BernardoSemiOficial BernardoSemiOficial approved these changes

@tassioFront tassioFront tassioFront approved these changes

@mauriciomutte mauriciomutte mauriciomutte approved these changes

@schirrel schirrel schirrel approved these changes

@felipefialho felipefialho felipefialho approved these changes

@LucasGomestl LucasGomestl Awaiting requested review from LucasGomestl LucasGomestl was automatically assigned from juntossomosmais/frontenders-react

Assignees

@igorwessel igorwessel

Labels
bug Something isn't working package/core package/react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igorwessel @BernardoSemiOficial @felipefialho @schirrel @mauriciomutte @tassioFront