Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokens): compile ts files into js map on generate tokens script #162

Merged
merged 15 commits into from
Jun 30, 2023
Merged

feat(tokens): compile ts files into js map on generate tokens script #162

merged 15 commits into from
Jun 30, 2023

Conversation

RodrigoRVSN
Copy link
Contributor

@RodrigoRVSN RodrigoRVSN commented Jun 27, 2023 •
edited
Loading

Infos

Task

What is being delivered?

  • Change generate token script to create ts files in /src and compile to js using tsc, putting the mapped variables in dist
  • Put all tokens into a single index file, instead of dividing into other files

What impacts?

  • Atomium tokens package

Reversal plan

  • Reset commit to the previous version 0790171

Evidences

image

image

@RodrigoRVSN RodrigoRVSN requested a review from felipefialho June 27, 2023 18:11
@RodrigoRVSN RodrigoRVSN self-assigned this Jun 27, 2023
@RodrigoRVSN RodrigoRVSN marked this pull request as ready for review June 28, 2023 14:48
luiz-ortega
luiz-ortega previously approved these changes Jun 28, 2023
View reviewed changes
JulioCVaz
JulioCVaz previously approved these changes Jun 28, 2023
View reviewed changes
felipefialho
felipefialho reviewed Jun 28, 2023
View reviewed changes
packages/tokens/package.json Outdated Show resolved Hide resolved
packages/tokens/package.json Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-30 17:30 UTC

@RodrigoRVSN RodrigoRVSN marked this pull request as draft June 29, 2023 13:20
@RodrigoRVSN RodrigoRVSN dismissed stale reviews from luiz-ortega and JulioCVaz via a34c7b0 June 29, 2023 14:00
@RodrigoRVSN RodrigoRVSN marked this pull request as ready for review June 29, 2023 14:03
@RodrigoRVSN
Copy link
Contributor Author

Updated the script to generate a single index file exporting all the tokens, instead creating the {prefix}.ts file, to avoid errors trying to import the other elements

image

@RodrigoRVSN RodrigoRVSN marked this pull request as ready for review June 29, 2023 23:15
@RodrigoRVSN
Copy link
Contributor Author

@RodrigoRVSN, I have noticed the script folder is also been injected into the dist folder. How about avoid inject it there?

@tassioFront changed in the last commits. Used rimraf to remove the folder because I need to transform to ts and execute as a js

image

@RodrigoRVSN RodrigoRVSN requested review from lupy100, tassioFront and a team June 30, 2023 00:10
lupy100
lupy100 previously approved these changes Jun 30, 2023
View reviewed changes
felipefialho
felipefialho previously approved these changes Jun 30, 2023
View reviewed changes
tassioFront
tassioFront previously approved these changes Jun 30, 2023
View reviewed changes
@RodrigoRVSN RodrigoRVSN dismissed stale reviews from tassioFront, felipefialho, and lupy100 via b596e52 June 30, 2023 17:08
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@felipefialho felipefialho merged commit d5fd754 into main Jun 30, 2023
@felipefialho felipefialho deleted the feat/compile-ts-files-in-tokens-script branch June 30, 2023 17:26
This was referenced Jul 4, 2023
Merged
Merged
This was referenced Jul 17, 2023
Merged
Closed
Closed
This was referenced Jul 31, 2023
Closed
Merged
Merged
felipefialho added a commit that referenced this pull request Aug 3, 2023
@RodrigoRVSN @felipefialho
feat(tokens): compile ts files into js map on generate tokens script (#…
f454660 
…162)

Co-authored-by: Felipe Fialho <hi@felipefialho.com>
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lupy100 lupy100 lupy100 left review comments

@tassioFront tassioFront tassioFront left review comments

@ldantas-s ldantas-s Awaiting requested review from ldantas-s

@JulioCVaz JulioCVaz Awaiting requested review from JulioCVaz

@luiz-ortega luiz-ortega Awaiting requested review from luiz-ortega

@felipefialho felipefialho Awaiting requested review from felipefialho

Assignees

@RodrigoRVSN RodrigoRVSN

Labels
package/tokens
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RodrigoRVSN @tassioFront @felipefialho @JulioCVaz @lupy100 @luiz-ortega