fix: exports in icon component

juntossomosmais · Apr 26, 2023 · 1fdcc3b · 1fdcc3b
1 parent 7698cc5
commit 1fdcc3b
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 5 deletions.
diff --git a/packages/core/src/components.d.ts b/packages/core/src/components.d.ts
@@ -4,10 +4,9 @@
  * This is an autogenerated file created by the Stencil compiler.
  * It contains typing information for all components that exist in this project.
  */
-import { Mode, TextFieldTypes } from "@ionic/core";
 import { HTMLStencilElement, JSXBase } from "@stencil/core/internal";
+import { Color, Mode, TextFieldTypes } from "@ionic/core";
 export { Color, Mode, TextFieldTypes } from "@ionic/core";
-export { LocalJSX as JSX };
 export namespace Components {
     interface AtomButton {
         "color": 'primary' | 'secondary';
@@ -34,6 +33,11 @@ export namespace Components {
     interface AtomGrid {
         "fixed"?: boolean;
     }
+    interface AtomIcon {
+        "color"?: Color;
+        "icon"?: string;
+        "size"?: 'small' | 'large';
+    }
     interface AtomInput {
         "accept"?: string;
         "autofocus": boolean;
@@ -117,6 +121,12 @@ declare global {
         prototype: HTMLAtomGridElement;
         new (): HTMLAtomGridElement;
     };
+    interface HTMLAtomIconElement extends Components.AtomIcon, HTMLStencilElement {
+    }
+    var HTMLAtomIconElement: {
+        prototype: HTMLAtomIconElement;
+        new (): HTMLAtomIconElement;
+    };
     interface HTMLAtomInputElement extends Components.AtomInput, HTMLStencilElement {
     }
     var HTMLAtomInputElement: {
@@ -139,6 +149,7 @@ declare global {
         "atom-button": HTMLAtomButtonElement;
         "atom-col": HTMLAtomColElement;
         "atom-grid": HTMLAtomGridElement;
+        "atom-icon": HTMLAtomIconElement;
         "atom-input": HTMLAtomInputElement;
         "atom-row": HTMLAtomRowElement;
         "atom-select": HTMLAtomSelectElement;
@@ -171,6 +182,11 @@ declare namespace LocalJSX {
     interface AtomGrid {
         "fixed"?: boolean;
     }
+    interface AtomIcon {
+        "color"?: Color;
+        "icon"?: string;
+        "size"?: 'small' | 'large';
+    }
     interface AtomInput {
         "accept"?: string;
         "autofocus"?: boolean;
@@ -234,17 +250,20 @@ declare namespace LocalJSX {
         "atom-button": AtomButton;
         "atom-col": AtomCol;
         "atom-grid": AtomGrid;
+        "atom-icon": AtomIcon;
         "atom-input": AtomInput;
         "atom-row": AtomRow;
         "atom-select": AtomSelect;
     }
 }
+export { LocalJSX as JSX };
 declare module "@stencil/core" {
     export namespace JSX {
         interface IntrinsicElements {
             "atom-button": LocalJSX.AtomButton & JSXBase.HTMLAttributes<HTMLAtomButtonElement>;
             "atom-col": LocalJSX.AtomCol & JSXBase.HTMLAttributes<HTMLAtomColElement>;
             "atom-grid": LocalJSX.AtomGrid & JSXBase.HTMLAttributes<HTMLAtomGridElement>;
+            "atom-icon": LocalJSX.AtomIcon & JSXBase.HTMLAttributes<HTMLAtomIconElement>;
             "atom-input": LocalJSX.AtomInput & JSXBase.HTMLAttributes<HTMLAtomInputElement>;
             "atom-row": LocalJSX.AtomRow & JSXBase.HTMLAttributes<HTMLAtomRowElement>;
             "atom-select": LocalJSX.AtomSelect & JSXBase.HTMLAttributes<HTMLAtomSelectElement>;

diff --git a/packages/core/src/components/icon/icon.spec.ts b/packages/core/src/components/icon/icon.spec.ts
@@ -1,6 +1,8 @@
 import { newSpecPage } from '@stencil/core/testing'
 
-import { AtomIcon, CDN_URL } from './icon'
+import { AtomIcon } from './icon'
+
+const URL_MOCK = 'https://unpkg.com/ionicons@7.1.0/dist/ionicons/svg'
 
 describe('atom-icon', () => {
   it('should render ion-icon element', async () => {
@@ -18,7 +20,7 @@ describe('atom-icon', () => {
     expect(page.root).toEqualHtml(`
       <atom-icon color="primary" icon="heart" size="large">
         <mock:shadow-root>
-          <ion-icon color="primary" icon="${CDN_URL}/heart.svg" size="large"></ion-icon>
+          <ion-icon color="primary" icon="${URL_MOCK}/heart.svg" size="large"></ion-icon>
         </mock:shadow-root>
       </atom-icon>
     `)

diff --git a/packages/core/src/components/icon/icon.tsx b/packages/core/src/components/icon/icon.tsx
@@ -1,7 +1,7 @@
 import { Color } from '@ionic/core'
 import { Component, Prop, h } from '@stencil/core'
 
-export const CDN_URL = 'https://unpkg.com/ionicons@7.1.0/dist/ionicons/svg'
+const CDN_URL = 'https://unpkg.com/ionicons@7.1.0/dist/ionicons/svg'
 
 @Component({
   tag: 'atom-icon',