-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CamelCase Display Name Generator #1595
Comments
@sormuras are there anyone already working on this issue? I can work on it. |
Hi @andreybleme sure -- but wait until #1588 was merged to |
@sormuras ok I'm waiting for it. Thanks. |
Ready, set... Go! The Display Name Generator SPI is now available. |
Seems that @zoltanersek already did it. I'll move to another issue. |
is this wrapped up? Can we remove the "up for grabs" label, if so? |
Before implementing such a generator, we should come up with a table of example method names and agree on what the generated display names should be. Thus, I've changed the status to blocked for the time being. |
Hi, @marcphilipp I would like to take a step on this, I can make a table with examples for team discussion and clarification on how this should be displayed, in order to remove the blocker and finish if there are missing modifications, sounds good? |
@Kazhuru Sure, that sounds good! 👍 |
This comment has been minimized.
This comment has been minimized.
Hi there, I would like to propose this kind of output activity for this generator:
I dont' know if we could aggregate more scenarios or this is a good output? |
Couldn't this be at least integrated into https://github.com/junit-pioneer/junit-pioneer in form that @Kazhuru suggested instead of being still blocked after 7 months :/? |
Sure, that sounds like a good idea! |
Team decision: Since there are so many edge cases we feel that it might be not be feasible to implement an out-of-the-box general purpose camel case generator that meets the majority of users' needs. Thus, we close this issue for now. If you need one, the API is extensible by design and you can write your own. |
Overview
As a follow-up from #1588 use the
DisplayNameGenerator
SPI to turn names of test classes and test methods using camel-case notation into human-readable display names.Related Issues
Deliverables
CamelCaseGenerator
inorg.junit.jupiter.api.DisplayNameGenerator
org.junit.jupiter.engine.descriptor.DisplayNameUtils
org.junit.jupiter.api.DisplayNameGenerationTests
to verify the implementationThe text was updated successfully, but these errors were encountered: