Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added supporting for comparing CharSequence objects. Added tests. #1533

Closed
wants to merge 1 commit into from
Closed

Conversation

IgorNosach25
Copy link

"Asserts for CharSequence contents #1432" is resolved. Please apply my changes.

@kcooney
Copy link
Member

kcooney commented Jun 8, 2018

Thanks for the contribution.

If JUnit has assertions for CharSequence (and I am not 100% convinced it should) I prefer to iterate on #1439

Note there are many projects that focus on making comprehensive assertion APIs (Hamcrest, Fest, Truth...), so we sometimes decline requests to add new kinds of assertions to JUnit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants