Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1189: JUnit4TestAdapter blocks JUnit-3-style suites that are included via @RunWith(Suite.class) #1344

Merged
merged 2 commits into from
Oct 8, 2016
Merged

Fixes #1189: JUnit4TestAdapter blocks JUnit-3-style suites that are included via @RunWith(Suite.class) #1344

merged 2 commits into from
Oct 8, 2016

Conversation

kcooney
Copy link
Member

@kcooney kcooney commented Jul 17, 2016

No description provided.

@kcooney kcooney mentioned this pull request Jul 17, 2016
Closed
@kcooney kcooney force-pushed the issue1189 branch 2 times, most recently from 783b55e to 05e3cab Compare July 17, 2016 02:35
@kcooney kcooney added the 4.13 label Jul 17, 2016
@kcooney kcooney force-pushed the issue1189 branch 3 times, most recently from bbdd09d to 33a4cc6 Compare July 17, 2016 03:24
@kcooney
Copy link
Member Author

kcooney commented Jul 30, 2016

@junit-team/junit-committers any concerns with this?

@kcooney
Copy link
Member Author

kcooney commented Aug 3, 2016

@stefanbirkner CustomAllDefaultPossibilitiesBuilder cannot be static, because it creates an instance of CustomSuiteMethodBuilder, which also cannot be static.

@stefanbirkner
Copy link
Contributor

@kcooney I saw this afterwards. Sorry for posting the comment to early.

@kcooney
Copy link
Member Author

kcooney commented Aug 3, 2016

@stefanbirkner no problem. Any concerns with me merging this pull?

@stefanbirkner
Copy link
Contributor

LGTM

@kcooney kcooney merged commit 25495b3 into junit-team:master Oct 8, 2016
@kcooney
Copy link
Member Author

kcooney commented Oct 8, 2016

@mkeller thanks for the help fix (and sorry for the delay in merging. Could you update the 4.13 release notes (on the wiki) to include this?

@kcooney kcooney deleted the issue1189 branch October 8, 2016 18:15
@kcooney kcooney modified the milestone: 4.13 Aug 6, 2017
@kcooney kcooney removed the 4.13 label Aug 6, 2017
sebasjm pushed a commit to sebasjm/junit4 that referenced this pull request Mar 11, 2018
@kcooney
Fixes junit-team#1189: JUnit4TestAdapter blocks JUnit-3-style suites …
cfba769 
…that are included via @RunWith(Suite.class) (junit-team#1344)

* Fixes junit-team#1189: JUnit4TestAdapter blocks JUnit-3-style suites that are included via @RunWith(Suite.class)

* Redo fix of 1189 in a way that won't break code that subclasses AllDefaultPossibilitiesBuilder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.13-beta-1
Development

Successfully merging this pull request may close these issues.
3 participants
@kcooney @stefanbirkner @mkeller