[fish] Fix for directories with special characters #4230
Conversation
|
Can you mention some test cases in the commit message? |
Using CTRL-T or ALT-C when the current command line token contained a directory with special characters, the script would fail to detect it. For exampe, an existing directory named `it\'s\ a\ test`, instead of using it as walker-root, it would use it as the query.
|
I added a commit message. Let me know if it needs more info. |
|
Thanks, I've just tested the code and it does fix the issue. mkdir "it's a test"
touch "it's a test"/foo
ls it\'s\ a\ test/<CTRL-T>
# Works as expectedBut I noticed a slight difference with bash and zsh's fuzzy completion. ls it\'s\ a\ t<CTRL-T>
# Starts fzf with "it\'s\ a\ t"
# In bash and zsh, `ls it\'s\ a\ t**<TAB>`, starts fzf with "it's a t"I don't think this is necessarily a problem, because CTRL-T of fish is not supposed to behave identical to them. I'm just wondering how you feel about it. |
|
This is not a regression from this change. Currently, in fish, the query from the command line token is processed exactly as if it was typed in fzf prompt. So, in this example, only the spaces should be escaped. This allows for less typing and not worrying about escaping and open quotes, but I understand that it can also be confusing, especially if the token for the query was created by the shell's auto-completion. We could probably change that, but I think we would have to use the |
|
Considering #4196 and this is not a regression, I think we should merge this as it is now. |
|
Merged, thanks again! |
If the current command line token contained a directory with special characters, the script would fail to detect it.