Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dotenv v3 usage #6

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Conversation

mcaskill
Copy link
Contributor

@mcaskill mcaskill commented Mar 4, 2019

Fixed:

  • Replaced occurrence of new Dotenv(…) with Dotenv::create(…)
  • Loosened version constraint on vlucas/phpdotenv

Changed:

  • Bumped version to 1.0.7

Fixed:
- Upgraded Dotenv API from v2
- Version constraint on "vlucas/phpdotenv"
@junaidbhura
Copy link
Owner

Hey @mcaskill what is the benefit of using Dotenv::create vs new Dotenv ?

Have you tested this with Windows, Mac and Linux?

@mcaskill
Copy link
Contributor Author

mcaskill commented Mar 5, 2019

Because the API has changed:

V3 has changed the way you initialize the Dotenv class. Consequently, you will need to replace any occurrences of new Dotenv(…) with Dotenv::create(…), since our new native constructor takes a Loader instance now.

Upgrading Guide, V2 to V3

@junaidbhura junaidbhura merged commit 8e15cf8 into junaidbhura:master Mar 5, 2019
@mcaskill mcaskill deleted the mcaskill-patch-7 branch March 5, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants