Nearly 0.6 compatible. Having some difficulties with usage of sub() #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes almost all of the deprecation notices and issues between the old version and 0.6.
There is a slight problem with the usage of
sub(). It seems like it should be possible to replacesub()withview(). However, I noticed that the original maintainer had a note concerning removingsub()calls for versions of julia after 0.4. I'm not sure what course of action would be best since there it seems that there was already something in the works.As I have it now, one of the tests is failing due to a call to
sub(). Most of this is unaffected by usage ofsub().