This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Disable benchmark logs #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logs are messing up the output meaning that perfcheck isn't able to compare some benchmarks.
Modern Go versions already excluded packages under the vendor directory by default when the `./...` wildcard is used.
TestMain isn't really necessary and it's best to isolate the gnatsd instance for each test for reliability reasons.
a2e6ba5 to
6c0f8f3
Compare
amnonbc
approved these changes
May 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logs are messing up the output meaning that perfcheck isn't able to compare some benchmarks.
Also:
vendordirectory in perfcheck. Modern Go versions do this by default.Once this lands, I'll merge the benchmark log suppression change into the
perfcheck-referencebranch so that all benchmarks are being compared again.