This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
listener: Protect batch buffer from concurrent access #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP listener uses concurrent HTTP handlers which were modifying the batch buffer without synchronisation. This resulted in data races and corrupt output from the listener. The test added in this change would reliably result in corrupt output before the mutex was added. The mutex is not required or used for the UDP listener as there is only one goroutine in that case.
oplehto
approved these changes
May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP listener uses concurrent HTTP handlers which were modifying the batch buffer without synchronisation. This resulted in data races and corrupt output from the listener. The test added in this change would reliably result in corrupt output before the mutex was added.
The mutex is not required or used for the UDP listener as there is only one goroutine in that case.