This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
listener: Prevent large HTTP POSTs from being broken up #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the way the batch buffer is handled, normalising the way reads for UDP and HTTP are done and separating batch buffer concerns from the main listener code. This paves the way for upcoming fixes.
This fixes an issue where a large HTTP POST, or a POST which arrives when the batch buffer is nearly full could get split, corrupting one of the lines contained within it. The batch buffer will now be grown if required to support any HTTP POST that arrives. Growing the batch buffer is expensive and the listener is arranged to minimise the chance of the buffer needing to grow at all. Growing the buffer is a fallback.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where a large HTTP POST, or a POST which arrives when the batch buffer is nearly full could get split, corrupting one of the lines contained within it.
Part of the fix involves cleaning up the way the batch buffer is handled, normalising the way reads for UDP and HTTP are done and separating batch buffer handling concerns from the main listener code.
The batch buffer will now be grown if required to support any HTTP POST that arrives. Growing the batch buffer is expensive and the listener is arranged to minimise the chance of the buffer needing to grow at all. Growing the buffer is a fallback.