This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
writer: Clean up subscription dropped reporting #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mjs
commented
Apr 24, 2018
- Always report drop counts for each subscription, instead of only when a drop is detected.
- Move the responsibility for reporting NATS drops to the statistician. This avoids a goroutine per subscription (which was probably overkill) and simplifies the code.
- Removed a lot of logging that was of dubious value (the metric provides the same information and scales better)
|
@oplehto I've left the name of the NATS dropped metric as What do you think? |
|
Changing the name is ok at this point. I'm not using it yet. |
oplehto
approved these changes
Apr 24, 2018
- Always report drop counts for each subscription, instead of only when a drop is detected. - Move the responsibility for reporting NATS drops to the statistician. This avoids a goroutine per subscription (which was probably overkill) and simplifies the code. - Removed a lot of logging that was of dubious value (the metric provides the same information and scales better) - Renamed "dropped" metric to "nats_dropped" to make the meaning clearer
a15e923 to
d2cc5c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.