-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
This will make it more convenient to generate Prometheus lines from a Stats.
New function to takes a Stats Snapshot and convert it to Prometheus metrics lines.
All usage of this have been replaced by AssertMonitor.
This helper is useful for cases where a single Prometheus metric line is required (instead of generating from a Snapshot).
No longer used now that the components are publishing metrics using Prometheus format.
This has been superseded by the Snapshot method.
Port 9331 has been allocated for use by influx-spout. See https://github.com/prometheus/prometheus/wiki/Default-port-allocations
One thing I'd like feedback on is the structure of the metrics reported by the various influx-spout components. For example, one of the listener's metrics looks like this:
All the metrics include at a minimum a label like this which identifies the component type and name. Is that sufficiently convenient? |
I haven't played around much with Prometheus yet but perhaps a preferrable approach would be to have This way we could set up Grafana templates in the form of |
@oplehto Yep, that sounds better. What's there now is just a direct mapping of the InfluxDB line protocol mappings but separating out the component type and name will make the metrics easier to deal with. I'll update the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This simplifies querying of influx-spout metrics.
This PR changes influx-spout so that all components report their own metrics in Prometheus format. These are consumed and aggregated by the monitor and are then served up over HTTP.
Highlights:
Clone()
)Stats.Clone()
(no longer used)I have registered port 9331 as the "official" default port for influx-spout Prometheus metrics (https://github.com/prometheus/prometheus/wiki/Default-port-allocations). This can of course be overridden through configuration.
I have tested the monitor
/metrics
HTTP endpoint with the telegraf Prometheus input to ensure that influx-spouts' metrics are correctly collected.Closes #29.