This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Rejection of invalid timestamps #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without doing this benchmark numbers of successive runs get merged together, with confusing/hilarious results.
oplehto
suggested changes
Mar 6, 2018
| w.processLine(line) | ||
| } else { | ||
| w.stats.Inc(linesInvalidTime) |
There was a problem hiding this comment.
We should add printing the failed line here if we are in debug mode. Hunting down the offender becomes much easier.
A new "max_time_delta_secs" configuration option has been added. If the filter sees a line with a timestamp which is outside ±max_time_delta_secs around the current time it will be reject. A new metric has been added to the filter which counts these rejected lines. This feature adds a 3-5% performance hit to the filter ProcessBatch benchmark, although this is largely lost when compared to the cost of matching any realistic number of filter rules (i.e. regex matching is expensive). Fixes #27.
This revision is the same as before except it has timestamps on the input lines, aligning it with the benchmark in master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new "max_time_delta_secs" configuration option has been added. If the filter sees a line with a timestamp which is outside ±max_time_delta_secs around the current time it will be reject. A new metric has been added to the filter which counts these rejected lines.
This feature adds a 3-5% performance hit to the filter ProcessBatch benchmark, although this is largely lost when compared to the cost of matching any realistic number of filter rules (i.e. regex matching is expensive).
Fixes #27.