This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
filter: Include name from config as tag in stats #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as is already done for the listener and writer. Fixes #20.
|
The test failure appears to be a pre-existing race. I'll take a look before merging. |
oplehto
approved these changes
Feb 22, 2018
Depending on timing, the test can sometimes see output from the stats goroutine before the test lines have been pushed through. The stats channel is now checked multiple times for the expected output to arrive.
|
I've fixed the occasional timing issue (fd9814a) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as is already done for the listener and writer.
Fixes #20.