Skip to content

Commit

Permalink
use StridedMaybeAdjOrTransMat instead of defining it (#217)
Browse files Browse the repository at this point in the history
  • Loading branch information
dkarrasch authored May 2, 2023
1 parent 677e5e7 commit 211e34e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MutableArithmetics"
uuid = "d8a4904e-b15c-11e9-3269-09a3773c0cb0"
authors = ["Gilles Peiffer", "Benoît Legat", "Sascha Timme"]
version = "1.2.3"
version = "1.2.4"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
7 changes: 1 addition & 6 deletions src/dispatch.jl
Original file line number Diff line number Diff line change
Expand Up @@ -538,16 +538,11 @@ function Base.:*(
return mul(A, B)
end

const StridedMaybeAdjOrTransMat{T} = Union{
StridedMatrix{T},
LinearAlgebra.Adjoint{T,<:StridedMatrix},
LinearAlgebra.Transpose{T,<:StridedMatrix},
}

# See https://github.com/JuliaLang/julia/pull/37898
# The default fallback only used `promote_type` so it may get its wrong, e.g.,
# for JuMP and MultivariatePolynomials.
if VERSION >= v"1.7.0-DEV.1284"
using LinearAlgebra: StridedMaybeAdjOrTransMat
_mat_mat_scalar(A, B, γ) = operate!!(*, operate(*, A, B), γ)
function LinearAlgebra.mat_mat_scalar(
A::StridedMaybeAdjOrTransMat{<:AbstractMutable},
Expand Down

2 comments on commit 211e34e

@dkarrasch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please release this so, so nanosoldier will see it?

@blegat
Copy link
Member

@blegat blegat commented on 211e34e May 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.