-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add iszero #643
✨ Add iszero #643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
- Coverage 95.29% 94.91% -0.38%
==========================================
Files 49 49
Lines 5272 5431 +159
==========================================
+ Hits 5024 5155 +131
- Misses 248 276 +28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a test? The test should cover that iszero(f)
is true iff f == zero(f)
as the Julia documentation suggests.
Fallbacks to
zero(f)
by default which is not implemented (only implemented for its type) and is disputed #636.Required by jump-dev/SumOfSquares.jl#71