Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add iszero #643

Merged
merged 4 commits into from
Feb 5, 2019
Merged

✨ Add iszero #643

merged 4 commits into from
Feb 5, 2019

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 25, 2019

Fallbacks to zero(f) by default which is not implemented (only implemented for its type) and is disputed #636.
Required by jump-dev/SumOfSquares.jl#71

@codecov-io
Copy link

codecov-io commented Jan 25, 2019

Codecov Report

Merging #643 into master will decrease coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   95.29%   94.91%   -0.38%     
==========================================
  Files          49       49              
  Lines        5272     5431     +159     
==========================================
+ Hits         5024     5155     +131     
- Misses        248      276      +28
Impacted Files Coverage Δ
src/Utilities/functions.jl 96.71% <100%> (-0.89%) ⬇️
src/Utilities/parser.jl 86.71% <0%> (-10.94%) ⬇️
src/functions.jl 96.49% <0%> (-3.51%) ⬇️
src/Bridges/quadtosocbridge.jl 90.9% <0%> (-1.52%) ⬇️
src/Utilities/results.jl 87.64% <0%> (-1.13%) ⬇️
src/Test/modellike.jl 97.85% <0%> (-0.72%) ⬇️
src/Bridges/slackbridge.jl 100% <0%> (ø) ⬆️
src/Bridges/soctopsdbridge.jl 100% <0%> (ø) ⬆️
src/Bridges/lazybridgeoptimizer.jl 100% <0%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06b8f4...5763400. Read the comment docs.

Copy link
Member

@mlubin mlubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a test? The test should cover that iszero(f) is true iff f == zero(f) as the Julia documentation suggests.

@blegat blegat merged commit 018dfcd into master Feb 5, 2019
@odow odow deleted the bl/iszero branch March 6, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants