Add VariableInSetRef and has_variable_in_set #3955
Open
+365
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3955 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 6054 6085 +31
=========================================
+ Hits 6054 6085 +31 ☔ View full report in Codecov by Sentry. |
blegat
reviewed
Feb 28, 2025
| @@ -1308,6 +1308,40 @@ julia> x = @variable(model, [1:3], set = SecondOrderCone()) | |||
| You cannot delete the constraint associated with a variable constrained on | |||
| creation. | |||
|
|
|||
| To check if a variable was constrained on creation, use [`has_variable_in_set`](@ref), | |||
There was a problem hiding this comment.
Suggested change
| To check if a variable was constrained on creation, use [`has_variable_in_set`](@ref), | |
| To check if a variable was constrained on creation, use [`is_variable_in_set`](@ref), |
blegat
reviewed
Feb 28, 2025
| model = owner_model(x) | ||
| ci = get(model.variable_in_set_ref, x, nothing) | ||
| if ci === nothing | ||
| error("VariableInSetRef does not exist for $x") |
There was a problem hiding this comment.
Suggested change
| error("VariableInSetRef does not exist for $x") | |
| error("`VariableInSetRef` does not exist for `$x`") |
blegat
reviewed
Feb 28, 2025
| if ci !== nothing # ci === nothing if variable.set isa MOI.Reals | ||
| model.variable_in_set_ref[ret] = ci | ||
| if variable.shape != ScalarShape() && variable.shape != VectorShape() | ||
| model.shapes[ci] = variable.shape |
There was a problem hiding this comment.
It's nice that the shape can work as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3951