Use _string_round when printing sets #3341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3341 +/- ##
==========================================
+ Coverage 97.92% 98.05% +0.12%
==========================================
Files 34 34
Lines 4874 4876 +2
==========================================
+ Hits 4773 4781 +8
+ Misses 101 95 -6
☔ View full report in Codecov by Sentry. |
blegat
approved these changes
May 3, 2023
There was a problem hiding this comment.
I'm in favor of this. In the future, we can have printing options and make it optional but I would round by default. Even if power users might be interested to see that these are floating point numbers, most users like the abstraction and prefer to thing about math instead of having to worry about technical details.
|
I guess we can aways revisit when we add generic number support. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3339
I don't know about this. If we're thinking of supporting arbitrary number types in JuMP, I'd lean the other way, and remove the rounding when printing?