OptimizerWithAttributes direct model constructor #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
May 25, 2021
Codecov Report
@@ Coverage Diff @@
## master #2614 +/- ##
==========================================
+ Coverage 93.46% 93.50% +0.03%
==========================================
Files 44 44
Lines 5542 5544 +2
==========================================
+ Hits 5180 5184 +4
+ Misses 362 360 -2
Continue to review full report at Codecov.
|
odow
reviewed
May 26, 2021
odow
approved these changes
May 26, 2021
blegat
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to create a direct model when the user passes an
OptimizerWithAttributes. The rationale is to reuse solver definitions for different model options.