Allow overloading of container types #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2570 +/- ##
==========================================
+ Coverage 93.37% 93.45% +0.07%
==========================================
Files 44 44
Lines 5511 5514 +3
==========================================
+ Hits 5146 5153 +7
+ Misses 365 361 -4
Continue to review full report at Codecov.
|
blegat
reviewed
Apr 22, 2021
blegat
reviewed
Apr 22, 2021
|
@blegat how's this? |
blegat
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There didn't seem to be a good reason to have the error.
This should make it easy to add
AxisKeysas a backing type:Closes #2523
And we now currently support
<:AbstractDict, which avoids the need to makeSparseAxisArrayanAbstractDict:Closes #2176