Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell check #2555

Merged
merged 4 commits into from
Apr 11, 2021
Merged

Spell check #2555

merged 4 commits into from
Apr 11, 2021

Conversation

remi-garcia
Copy link
Contributor

I am checking for misspellings, using tools obviously. It is still in progress but I have a few questions:

  • Should we use British English or American English? (e.g. for modelled/modeled)
  • I replaced "arguement" with "argument" because I understood that the second is correct in British English and American English, is that right?

@codecov
Copy link

codecov bot commented Apr 10, 2021

Codecov Report

Merging #2555 (67eef38) into master (54c3c2c) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2555      +/-   ##
==========================================
+ Coverage   92.94%   93.17%   +0.22%     
==========================================
  Files          44       44              
  Lines        5457     5479      +22     
==========================================
+ Hits         5072     5105      +33     
+ Misses        385      374      -11     
Impacted Files Coverage Δ
src/Containers/vectorized_product_iterator.jl 76.19% <ø> (+7.44%) ⬆️
src/JuMP.jl 83.03% <ø> (+0.73%) ⬆️
src/constraints.jl 94.97% <ø> (ø)
src/feasibility_checker.jl 100.00% <ø> (ø)
src/lp_sensitivity.jl 93.78% <ø> (ø)
src/macros.jl 92.91% <ø> (ø)
src/nlp.jl 92.06% <ø> (ø)
src/variables.jl 98.78% <ø> (ø)
src/Containers/DenseAxisArray.jl 88.33% <0.00%> (+1.18%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c3c2c...67eef38. Read the comment docs.

@mlubin
Copy link
Member

mlubin commented Apr 10, 2021

This is very helpful, thanks!

Should we use British English or American English?

American

@remi-garcia remi-garcia changed the title [WIP] Spell check Spell check Apr 11, 2021
@remi-garcia
Copy link
Contributor Author

Checking is done. I also replaced some http links with https ones.

Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful! What tools did you use for this?

@odow odow merged commit 45ce630 into jump-dev:master Apr 11, 2021
@remi-garcia
Copy link
Contributor Author

remi-garcia commented Apr 11, 2021

Oh, nothing fancy. I just managed to have my spell check working in Atom (which was harder than it looks). Then it was mostly by hand.

Sorry if

using tools obviously

was misleading, it was to emphasize on the fact that despite my poor English corrections should be fine.

Edit: Speaking of tools, I heard about Check Spelling (https://github.com/marketplace/actions/check-spelling) but still do not have tried it

@remi-garcia remi-garcia deleted the rg/typo branch April 11, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants