Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow iterators of unknown size in macros #2550

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Allow iterators of unknown size in macros #2550

merged 7 commits into from
Apr 7, 2021

Conversation

odow
Copy link
Member

@odow odow commented Mar 31, 2021

Closes #1915

@odow odow added Category: Containers Related to the Containers submodule Type: Bug labels Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #2550 (591c63a) into master (54c3c2c) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2550      +/-   ##
==========================================
+ Coverage   92.94%   93.13%   +0.19%     
==========================================
  Files          44       44              
  Lines        5457     5481      +24     
==========================================
+ Hits         5072     5105      +33     
+ Misses        385      376       -9     
Impacted Files Coverage Δ
src/Containers/vectorized_product_iterator.jl 76.19% <100.00%> (+7.44%) ⬆️
src/Containers/DenseAxisArray.jl 88.33% <0.00%> (+1.18%) ⬆️
src/parse_nlp.jl 95.50% <0.00%> (+4.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c3c2c...591c63a. Read the comment docs.

@odow odow requested a review from blegat April 5, 2021 22:57
@odow odow merged commit b6d9ddf into master Apr 7, 2021
@odow odow deleted the od/iterator branch April 7, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Containers Related to the Containers submodule Type: Bug
Development

Successfully merging this pull request may close these issues.

[Useability] @constraint and @variable: cannot use an iterator
2 participants