Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] white background for logo #2535

Closed
wants to merge 1 commit into from
Closed

[docs] white background for logo #2535

wants to merge 1 commit into from

Conversation

odow
Copy link
Member

@odow odow commented Mar 23, 2021

Not sure if we should merge this. Just checking what it looks like

Closes #2492

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #2535 (3cdc30e) into master (795fd25) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2535   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          45       45           
  Lines        5473     5473           
=======================================
  Hits         5118     5118           
  Misses        355      355           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 795fd25...3cdc30e. Read the comment docs.

@odow
Copy link
Member Author

odow commented Mar 23, 2021

Preview: https://jump.dev/JuMP.jl/previews/PR2535/index.html#
@joaquimg I don't think this improves anything
image

Other ideas? Documenter doesn't seem to support switching out an image based on the theme.

@odow odow closed this Apr 14, 2021
@odow odow deleted the odow-patch-2 branch April 14, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

JuMP logo on night/dark theme
1 participant