Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the examples by categorizing them into broader themes. #2443

Closed
wants to merge 1 commit into from

Conversation

odow
Copy link
Member

@odow odow commented Jan 31, 2021

Doc preview: https://jump.dev/JuMP.jl/previews/PR2443/examples/mixed-integer-linear-programs/

Our current examples are just a large list. This makes it hard to figure out which ones are MILP/SDP/nonlinear etc.

image

This PR copy-pastes the existing examples into broader themes (e.g., mixed-integer linear programs, nonlinear programs, and semi-definite programs) to make it easier to find ones of interest.

image

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #2443 (6774f11) into master (dd91677) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2443   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          43       43           
  Lines        4634     4634           
=======================================
  Hits         4275     4275           
  Misses        359      359           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd91677...6774f11. Read the comment docs.

@blegat
Copy link
Member

blegat commented Feb 1, 2021

Why do they all have to be in the same files ? Can't we do subdirs as in #2444 ?

@odow
Copy link
Member Author

odow commented Feb 1, 2021

I did this first, then found the subdir trick worked quite well! Here's the alternative: #2445

@odow
Copy link
Member Author

odow commented Feb 1, 2021

Closing in favor of #2445

@odow odow closed this Feb 1, 2021
@odow odow deleted the od/examples branch February 1, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants