Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error for printing in IJuliaMode #2420

Merged
merged 11 commits into from
Jan 5, 2021
Merged

Fix error for printing in IJuliaMode #2420

merged 11 commits into from
Jan 5, 2021

Conversation

guilhermebodin
Copy link
Contributor

@guilhermebodin guilhermebodin commented Jan 2, 2021 •
edited by odow
Loading

Fixes #2293

Captura de Tela 2021-01-02 às 02 59 30

@codecov
Copy link

codecov bot commented Jan 2, 2021 •
edited
Loading

Codecov Report

Merging #2420 (ca65047) into master (2b0d910) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
+ Coverage   92.26%   92.27%   +0.01%     
==========================================
  Files          43       43              
  Lines        4614     4623       +9     
==========================================
+ Hits         4257     4266       +9     
  Misses        357      357
Impacted Files Coverage Δ
src/print.jl 91.50% <100.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0d910...ca65047. Read the comment docs.

@joaquimg
Copy link
Member

joaquimg commented Jan 4, 2021

Does it work for negative exponents?

@guilhermebodin
Copy link
Contributor Author

Probably not

@guilhermebodin
Copy link
Contributor Author

Fixed some more corner cases

Captura de Tela 2021-01-04 às 01 30 15

odow
odow reviewed Jan 4, 2021
View reviewed changes
odow
odow reviewed Jan 4, 2021
View reviewed changes
@guilhermebodin guilhermebodin requested a review from odow January 4, 2021 18:09
odow
odow requested changes Jan 4, 2021
View reviewed changes
@guilhermebodin guilhermebodin requested a review from odow January 4, 2021 21:12
odow
odow approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@odow odow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming tests pass.They do.

@odow
Copy link
Member

odow commented Jan 4, 2021

I found a similar problem: #2422

@odow odow merged commit d2398ad into jump-dev:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odow odow odow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Powers print incorrectly in IJulia mode
3 participants
@guilhermebodin @joaquimg @odow