Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setindex! internally #2418

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Use setindex! internally #2418

merged 2 commits into from
Dec 17, 2020

Conversation

blegat
Copy link
Member

@blegat blegat commented Dec 16, 2020

These were part of #2232

@odow
Copy link
Member

odow commented Dec 16, 2020

Looks like you need to define setindex! for JuMPExtension.

@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #2418 (45ece26) into master (a945fb0) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2418      +/-   ##
==========================================
+ Coverage   92.18%   92.23%   +0.04%     
==========================================
  Files          43       43              
  Lines        4595     4596       +1     
==========================================
+ Hits         4236     4239       +3     
+ Misses        359      357       -2     
Impacted Files Coverage Δ
src/JuMP.jl 78.49% <100.00%> (+1.19%) ⬆️
src/copy.jl 88.23% <100.00%> (ø)
src/macros.jl 92.13% <100.00%> (ø)
src/variables.jl 98.46% <0.00%> (ø)
src/constraints.jl 93.42% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a945fb0...45ece26. Read the comment docs.

@odow odow merged commit 994feba into master Dec 17, 2020
@odow odow deleted the bl/setindex branch December 17, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants