Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when copying model with named expressions #2405

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Fix bug when copying model with named expressions #2405

merged 3 commits into from
Dec 14, 2020

Conversation

odow
Copy link
Member

@odow odow commented Dec 14, 2020

Closes #2403

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2405 (5f991d8) into master (90e63c4) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2405      +/-   ##
==========================================
+ Coverage   91.67%   91.86%   +0.19%     
==========================================
  Files          42       42              
  Lines        4456     4462       +6     
==========================================
+ Hits         4085     4099      +14     
+ Misses        371      363       -8     
Impacted Files Coverage Δ
src/copy.jl 88.23% <100.00%> (+3.61%) ⬆️
src/quad_expr.jl 96.20% <0.00%> (+1.23%) ⬆️
src/aff_expr.jl 95.20% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e63c4...5f991d8. Read the comment docs.

@odow odow merged commit 33a34d6 into master Dec 14, 2020
@odow odow deleted the od/expr_bug branch December 14, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Error copying a model having expressions
2 participants