Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define haskey for JuMP AbstractModel #2363

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Define haskey for JuMP AbstractModel #2363

merged 6 commits into from
Nov 10, 2020

Conversation

andrewrosemberg
Copy link
Contributor

Overloads Base.haskey for JuMP.AbstractModel.

Relates to #1887

joaquimg
joaquimg reviewed Oct 28, 2020
View reviewed changes
joaquimg
joaquimg reviewed Oct 28, 2020
View reviewed changes
andrewrosemberg added 2 commits October 28, 2020 16:49
@guilhermebodin
Copy link
Contributor

https://jump.dev/JuMP.jl/v0.21.5/style/#Return-statements-1 Maybe it needs a return to follow the style guide

blegat
blegat reviewed Oct 28, 2020
View reviewed changes
blegat
blegat approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@joaquimg joaquimg merged commit 4b677ef into jump-dev:master Nov 10, 2020
@odow odow mentioned this pull request Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat approved these changes

@joaquimg joaquimg joaquimg approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewrosemberg @guilhermebodin @blegat @joaquimg