Don't create a testset for each potential test file. #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the output when running the tests, as there is no output for files that are excluded. Previously, the output was like: Test Summary: | Pass Total Containers | 241 241 Containers.jl took 37.4 seconds. Test Summary: | JuMPExtension.jl | No tests callbacks.jl took 15.9 seconds. Test Summary: | Pass Total callbacks.jl | 22 22 With this patch: Test Summary: | Pass Total Containers | 241 241 Containers.jl took 22.0 seconds. callbacks.jl took 16.8 seconds. Test Summary: | Pass Total callbacks.jl | 22 22
odow
approved these changes
Sep 21, 2020
blegat
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the output when running the tests, as there is no output for files that are excluded.
Previously, the output was like:
With this patch: