Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: function-ize model.jl #2303

Merged
merged 1 commit into from
Aug 8, 2020
Merged

tests: function-ize model.jl #2303

merged 1 commit into from
Aug 8, 2020

Conversation

IainNZ
Copy link
Collaborator

@IainNZ IainNZ commented Aug 2, 2020

Tested locally by running the file and running runtests.jl, seems fine?

Only marginally faster, order of a second on a ~40 second base.

@IainNZ IainNZ requested a review from odow August 2, 2020 19:31
@codecov
Copy link

codecov bot commented Aug 2, 2020

Codecov Report

Merging #2303 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2303      +/-   ##
==========================================
- Coverage   91.39%   91.38%   -0.01%     
==========================================
  Files          42       42              
  Lines        4251     4250       -1     
==========================================
- Hits         3885     3884       -1     
  Misses        366      366              
Impacted Files Coverage Δ
src/copy.jl 87.50% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a270623...2a7af2d. Read the comment docs.

@odow odow merged commit b598d5b into master Aug 8, 2020
@odow odow deleted the iain/modeltest branch August 8, 2020 12:38
@odow odow mentioned this pull request Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants