Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating error message on ambiguous variable #2222

Merged
merged 3 commits into from
Jul 1, 2020

Conversation

yashvardhan747
Copy link
Contributor

@yashvardhan747 yashvardhan747 commented Apr 7, 2020

As keyword argument "category" no longer exist. Error message on ambiguous variable needs to be updated

Closes #2035

@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #2222 into master will increase coverage by 0.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2222      +/-   ##
==========================================
+ Coverage   91.12%   92.00%   +0.88%     
==========================================
  Files          42       42              
  Lines        4122     4864     +742     
==========================================
+ Hits         3756     4475     +719     
- Misses        366      389      +23     
Impacted Files Coverage Δ
src/macros.jl 93.75% <100.00%> (+1.12%) ⬆️
src/operators.jl 88.35% <0.00%> (-0.61%) ⬇️
src/callbacks.jl 100.00% <0.00%> (ø)
src/variables.jl 96.17% <0.00%> (+0.29%) ⬆️
src/Containers/SparseAxisArray.jl 81.73% <0.00%> (+1.21%) ⬆️
src/JuMP.jl 75.00% <0.00%> (+1.38%) ⬆️
src/constraints.jl 93.81% <0.00%> (+1.96%) ⬆️
src/nlp.jl 94.51% <0.00%> (+2.24%) ⬆️
src/objective.jl 94.00% <0.00%> (+2.82%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9192a...9b975c8. Read the comment docs.

@odow
Copy link
Member

odow commented Apr 13, 2020

Tests? Coverage is a little confused.

@yashvardhan747
Copy link
Contributor Author

yashvardhan747 commented Apr 13, 2020

Yeah cool, I add tests.
But the errors are LoadError, Can you tell how to test LoadError?

@yashvardhan747
Copy link
Contributor Author

Fine, I used @test_macro_throws :)

@odow odow closed this Jul 1, 2020
@odow odow reopened this Jul 1, 2020
Copy link
Member

@odow odow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting for the CI to pass. I had to give it a kick to restart a couple of times. Some sort of connection issue.

@blegat blegat merged commit c43b1f1 into jump-dev:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Old error message on ambiguous variable name. Keyword "category" no longer exists
3 participants