Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve the deprecation warning for with_optimizer #2165

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

mlubin
Copy link
Member

@mlubin mlubin commented Feb 17, 2020

I saw this warning and found it confusing:

julia> solver = with_optimizer(ECOS.Optimizer, verbose=0)
┌ Warning: `with_optimizer` is deprecated, replace `with_optimizer(Ipopt.Optimizer, max_cpu_time=60.0)`
│ by `optimizer_with_attributes(Ipopt.Optimizer, "max_cpu_time" => 60.0)`.

I don't have the line with_optimizer(Ipopt.Optimizer, max_cpu_time=60.0) in my code, so why is the message telling me to replace it?

IMO this should trigger 0.21.1, given that it affects all users updating from 0.20.

@mlubin mlubin force-pushed the ml/with_opt_warning branch from 255c3b8 to 6a91d0c Compare February 17, 2020 02:47
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #2165 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2165   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          42       42           
  Lines        4112     4112           
=======================================
  Hits         3747     3747           
  Misses        365      365
Impacted Files Coverage Δ
src/JuMP.jl 73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa08802...6a91d0c. Read the comment docs.

@blegat blegat added this to the 0.21.1 milestone Feb 17, 2020
@mlubin mlubin merged commit de63adf into master Feb 17, 2020
@mlubin mlubin deleted the ml/with_opt_warning branch February 17, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants