Added type info in NL error message #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
reviewed
Feb 18, 2019
There was a problem hiding this comment.
Great! Can you add some test cases please?
Here is an example
https://github.com/JuliaOpt/JuMP.jl/blob/1ee0e0284e3873bad20537362f3f567a7caa0f8a/test/nlp.jl#L569-L584
src/parse_nlp.jl
Outdated
| function _parse_NL_expr_runtime(m::Model, x::GenericAffExpr, tape, parent, values) | ||
| error("Unexpected affine expression $x in nonlinear expression. " * | ||
| "Affine expressions (e.g., created using @expression) and " * | ||
| "nonlinear expression cannot be mixed.") |
There was a problem hiding this comment.
Agreed... fixed.
mlubin
reviewed
Feb 18, 2019
test/nlp.jl
Outdated
| "Affine expressions (e.g., created using @expression) and " * | ||
| "nonlinear expressions cannot be mixed." | ||
| ) | ||
| @test_throws expected_exception @NLexpression(m, A) |
There was a problem hiding this comment.
Fixed in both places
|
Thanks! |
mlubin
pushed a commit
that referenced
this pull request
May 12, 2019
* Added type info in NL error message * Fix typo (twice) * Add tests for errors when using Aff/Quadx in NLexpressions * Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking for parsing nonlinear expression was missng the GenericAffExpr case. Also added type information to the catch-all error.