Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to the style guide #1781

Closed
wants to merge 11 commits into from
Closed

Updates to the style guide #1781

wants to merge 11 commits into from

Conversation

odow
Copy link
Member

@odow odow commented Jan 15, 2019

Ref #1780.

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #1781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1781   +/-   ##
=======================================
  Coverage   69.57%   69.57%           
=======================================
  Files          30       30           
  Lines        3957     3957           
=======================================
  Hits         2753     2753           
  Misses       1204     1204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350e948...7ec300d. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 15, 2019 •
edited
Loading

Codecov Report

Merging #1781 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1781   +/-   ##
=======================================
  Coverage   69.57%   69.57%           
=======================================
  Files          30       30           
  Lines        3957     3957           
=======================================
  Hits         2753     2753           
  Misses       1204     1204

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 350e948...67cfb56. Read the comment docs.

@odow odow mentioned this pull request Jan 15, 2019
Closed
40 tasks
mlubin
mlubin reviewed Jan 16, 2019
View reviewed changes
@mlubin
Copy link
Member

mlubin commented Jan 16, 2019

@odow This is too many subtle points to discuss in one PR. Please break it up into smaller chunks.

This was referenced Jan 16, 2019
Merged
Merged
Merged
Merged
Closed
Merged
@odow
Copy link
Member Author

odow commented Jan 16, 2019

Closing in favor of smaller PRs.

@odow odow closed this Jan 16, 2019
@odow odow deleted the od/style branch January 16, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blegat blegat blegat left review comments

@mlubin mlubin mlubin left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odow @mlubin @blegat