Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prerelease notes for 0.19-alpha #1523

Merged
merged 3 commits into from
Oct 10, 2018
Merged

prerelease notes for 0.19-alpha #1523

merged 3 commits into from
Oct 10, 2018

Conversation

mlubin
Copy link
Member

@mlubin mlubin commented Oct 6, 2018

After merging this I'll tag v0.19-alpha. I'm not certain that add JuMP#v0.19-alpha will work though.

@blegat @odow @joaquimg @joehuchette @juan-pablo-vielma @IssamT

Please take a look and check that you agree with the lists of breaking changes/new features/known issues.

Copy link
Contributor

@joehuchette joehuchette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

NEWS.md Outdated
of lists. Duplicate coefficients can no longer exist. Accessors and iteration
methods have changed.

- `JuMPNLPEvaluator` no longer includes the the linear and quadratic and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated "and quadratic"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also duplicated "the"

NEWS.md Outdated

New features:

- Support for deleting constraints and variables
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: End with period (here and below).

@codecov
Copy link

codecov bot commented Oct 6, 2018

Codecov Report

Merging #1523 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1523     +/-   ##
=========================================
+ Coverage   89.47%   89.58%   +0.1%     
=========================================
  Files          27       27             
  Lines        3621     3736    +115     
=========================================
+ Hits         3240     3347    +107     
- Misses        381      389      +8
Impacted Files Coverage Δ
src/quad_expr.jl 87.95% <0%> (-1.93%) ⬇️
src/JuMP.jl 75.67% <0%> (-0.52%) ⬇️
src/nlp.jl 90.55% <0%> (+0.06%) ⬆️
src/variables.jl 93.45% <0%> (+0.11%) ⬆️
src/aff_expr.jl 93.16% <0%> (+0.24%) ⬆️
src/macros.jl 88.46% <0%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e1e16...3052ada. Read the comment docs.

@blegat
Copy link
Member

blegat commented Oct 7, 2018

We could also mention that atm there is no automatic bridging between soc and quadratic while there was the conic <-> lpqp bridges with mpb but there are open prs for that

We could also advertise that JuMP extensibility has been improved as MOI is now extensible by design and JuMP macros are now extensible and a doc is coming

@mlubin
Copy link
Member Author

mlubin commented Oct 9, 2018

We could also mention that atm there is no automatic bridging between soc and quadratic while there was the conic <-> lpqp bridges with mpb but there are open prs for that

Is this a known issue or a breaking change (that it doesn't work anymore)?

@blegat
Copy link
Member

blegat commented Oct 9, 2018

Is this a known issue or a breaking change (that it doesn't work anymore)?

Not sure which yet. For quadratic to SOC, jump-dev/MathOptInterface.jl#483 does the non-homogeneous tranformation but I am not sure that the homogeneous one (i.e. x^2 + y^2 <= z^2) will be done for JuMP v0.19. For the SOC to quadratic, we are not sure to do it anymore because it would also work for NLP solvers: jump-dev/MathOptInterface.jl#478 (comment)

@mlubin mlubin merged commit a1d333e into master Oct 10, 2018
@odow odow deleted the ml/19news branch December 30, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants