Refactor how CI action exits

jump-dev · Mar 1, 2021 · 5c45dec · 5c45dec
1 parent bd1ea28
commit 5c45dec
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/.github/workflows/format_check.yml b/.github/workflows/format_check.yml
@@ -20,6 +20,12 @@ jobs:
           using Pkg
           Pkg.add(PackageSpec(name="JuliaFormatter", version="0.13.2"))
           using JuliaFormatter
-          ret = format("src", verbose=true)
-          ret = ret && format("test", verbose=true)
-          exit(ret ? 0 : 1)
+          format("src", verbose=true)
+          format("test", verbose=true)
+          out = String(read(Cmd(`git diff --name-only`)))
+          if isempty(out)
+              exit(0)
+          end
+          @error "Some files have not been formatted !!!"
+          write(stdout, out)
+          exit(1)
diff --git a/src/parse_nlp.jl b/src/parse_nlp.jl
@@ -125,7 +125,8 @@ function _parse_NL_expr(m, x, tapevar, parent, values)
                 push!(
                     block.args,
                     :(
-                        $lookupcode; push!(
+                        $lookupcode;
+                        push!(
                             $tapevar,
                             NodeData(CALLUNIVAR, operatorid, $parent),
                         )
@@ -194,12 +195,8 @@ function _parse_NL_expr(m, x, tapevar, parent, values)
                 end
                 push!(
                     block.args,
-                    :(
-                        $lookupcode; push!(
-                            $tapevar,
-                            NodeData(CALL, operatorid, $parent),
-                        )
-                    ),
+                    :($lookupcode;
+                    push!($tapevar, NodeData(CALL, operatorid, $parent))),
                 )
             end
             parentvar = gensym()